Merged
Conversation
8 tasks
Collaborator
jaredoconnell
left a comment
There was a problem hiding this comment.
Looks good overall. It is fairly self-contained, so it shouldn't cause any issues as long as the tests aren't flaky. Just one blocker as discussed in the call.
Collaborator
Author
|
@sjmonson I just straight up applied all of your suggestions. |
sjmonson
requested changes
Nov 5, 2025
Collaborator
sjmonson
left a comment
There was a problem hiding this comment.
One more nit. Also needs signoff, E.g. git rebase --signoff main.
Merged
4 tasks
7ad683b to
3c0d08b
Compare
sjmonson
approved these changes
Nov 6, 2025
markurtz
approved these changes
Nov 6, 2025
Signed-off-by: Alon Kellner <akellner@redhat.com>
3c0d08b to
ef3e541
Compare
sjmonson
added a commit
that referenced
this pull request
Nov 21, 2025
## Summary <!-- Include a short paragraph of the changes introduced in this PR. If this PR requires additional context or rationale, explain why the changes are necessary. --> Deduplicates much of the CI code by defining shared workflows and composite actions. Included in this is fixing some breakage introduced with #440 ## Details <!-- Provide a detailed list of all changes introduced in this pull request. --> This PR mostly keeps the same functionally as before with the main exception being pytest markers (when set) are now uniformly applied to all tests jobs. After this is approved the required CI list needs to be updates to enable merging. Some follow-up work (post this PR): - Deduplicate build and publish actions - Enable caching for shared workflow actions (such as pip installs, container builds) - Reduce coverage for certain stages - E.g. Run subset of tests on PRs ## Test Plan <!-- List the steps needed to test this PR. --> - See CI runs on this PR for results --- - [x] "I certify that all code in this PR is my own, except as noted below." ## Use of AI - [ ] Includes AI-assisted code completion - [ ] Includes code generated by an AI application - [ ] Includes AI-generated tests (NOTE: AI written tests should have a docstring that includes `## WRITTEN BY AI ##`)
sjmonson
added a commit
that referenced
this pull request
Dec 5, 2025
## Summary This PR adds over-saturation stopping to the GuideLLM CLI. It's based on the OSD (Over-Saturation Detection) algorithm we developed and evaluated at Jounce. Use `--stop-over-saturated` or `--stop-osd` to enable. ## Details This PR adds: - [x] Over-saturation stopping (`--stop-over-saturated`) - [x] Comprehensive OSD unit tests ## Test Plan - [x] Currently, only unit tests - [x] When #440 lands, we'll enable its over-saturation stopping E2E test --- - [x] "I certify that all code in this PR is my own, except as noted below." ## Use of AI - [x] Includes AI-assisted code completion - [x] Includes code generated by an AI application - [x] Includes AI-generated tests (NOTE: AI written tests should have a docstring that includes `## WRITTEN BY AI ##`)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
E2E tests which check basic GuideLLM functionality, using vLLM simulator.
Details
Test Plan
Use of AI
## WRITTEN BY AI ##)