stubgen.py: "@staticmethod" was used instead of "@classmethod" (#724)

wjakob · Sep 18, 2024 · 5b36d73 · 5b36d73
1 parent 90844bd
commit 5b36d73
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/src/stubgen.py b/src/stubgen.py
@@ -399,7 +399,7 @@ def put_function(self, fn: Callable[..., Any], name: Optional[str] = None, paren
             self.write_ln("@staticmethod")
             fn = fn.__func__
         elif isinstance(fn, classmethod):
-            self.write_ln("@staticmethod")
+            self.write_ln("@classmethod")
             fn = fn.__func__
 
         # Special handling for nanobind functions with overloads

diff --git a/tests/py_stub_test.py b/tests/py_stub_test.py
@@ -44,7 +44,7 @@ def static_method(x):
         pass
 
     @classmethod
-    def class_method(x):
+    def class_method(cls, x):
         pass
 
     @typing.overload

diff --git a/tests/py_stub_test.pyi.ref b/tests/py_stub_test.pyi.ref
@@ -15,8 +15,8 @@ class AClass:
     @staticmethod
     def static_method(x): ...
 
-    @staticmethod
-    def class_method(x): ...
+    @classmethod
+    def class_method(cls, x): ...
 
     @overload
     def overloaded(self, x: int) -> None: